fix: remove use of depricated insertIfNotExist from Files\Cache\Storage #43851
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
sorbaugh
and removed request for
a team
blizzz
approved these changes
Feb 27, 2024
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
storage-cache-not-exists
branch
2 times, most recently
from
e61c4a1
to
f11a83b
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
icewind1991
force-pushed
the
storage-cache-not-exists
branch
from
f11a83b
to
039b7e2
Compare
Merged
skjnldsv
added
2. developing
Merged
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
storage-cache-not-exists
branch
from
039b7e2
to
6ea4a97
Compare
blizzz
reviewed
Oct 2, 2024
| @@ -7,6 +7,7 @@ | |||
| */ | |||
| namespace OC\Files\Cache; | |||
|
|
|||
| use Doctrine\DBAL\Exception\UniqueConstraintViolationException; | |||
There was a problem hiding this comment.
shouldn't we have a OCP exception covering that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove legacy code